HypeTrain return empty shared_train_participants list if not shared_train#529
Draft
jrutschke wants to merge 1 commit intoPythonistaGuild:mainfrom
Draft
HypeTrain return empty shared_train_participants list if not shared_train#529jrutschke wants to merge 1 commit intoPythonistaGuild:mainfrom
jrutschke wants to merge 1 commit intoPythonistaGuild:mainfrom
Conversation
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DRAFT PR: should fix the issue, but waiting for event to occur again to verify
Small fix to fix to resolve TypeError for all hype train events. If not a shared train, return empty list for shared_train_participants.
Problem in BaseHypeTrain causes the same error for hype train begin, progress and end due to 'shared_train_participants' in event being None.
Checklist